[SPARK-41164][CONNECT] Update relations.proto to follow Connect proto development guide #38678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
changed the title
amaliujia
force-pushed
the
improve_relation_proto_to_follow_proto_rules
branch
from
be53f73
to
eef3333
Compare
HyukjinKwon
approved these changes
Nov 17, 2022
|
Merged to master. |
cloud-fan
reviewed
Nov 17, 2022
|
|
||
| // (Optional) The join condition. Could be unset when `using_columns` is utilized. | ||
| // | ||
| // This field does not co-exist with using_columns. | ||
| Expression join_condition = 3; |
There was a problem hiding this comment.
why is this not optional?
There was a problem hiding this comment.
This is Expression which is a message. By default it has has_field_name.
I think per current proto sytle guide we do not need optional for messages.
There was a problem hiding this comment.
In fact, not sure if we need to improve the proto style:
For a optional Message field, we also use optional to mark to keep consistency?
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
… development guide ### What changes were proposed in this pull request? As we have a guidance for Connect proto ([adding proto messages](https://github.com/apache/spark/blob/master/connector/connect/docs/adding-proto-messages.md)), this PR updates `relations.proto` to follow the development guide. This PR also adds some missing documentation for the proto. ### Why are the changes needed? 1. Follow development guide. 2. Improve proto Documentation. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? Existing UT Closes apache#38678 from amaliujia/improve_relation_proto_to_follow_proto_rules. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
… development guide ### What changes were proposed in this pull request? As we have a guidance for Connect proto ([adding proto messages](https://github.com/apache/spark/blob/master/connector/connect/docs/adding-proto-messages.md)), this PR updates `relations.proto` to follow the development guide. This PR also adds some missing documentation for the proto. ### Why are the changes needed? 1. Follow development guide. 2. Improve proto Documentation. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? Existing UT Closes apache#38678 from amaliujia/improve_relation_proto_to_follow_proto_rules. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
… development guide ### What changes were proposed in this pull request? As we have a guidance for Connect proto ([adding proto messages](https://github.com/apache/spark/blob/master/connector/connect/docs/adding-proto-messages.md)), this PR updates `relations.proto` to follow the development guide. This PR also adds some missing documentation for the proto. ### Why are the changes needed? 1. Follow development guide. 2. Improve proto Documentation. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? Existing UT Closes apache#38678 from amaliujia/improve_relation_proto_to_follow_proto_rules. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As we have a guidance for Connect proto (adding proto messages), this PR updates
relations.prototo follow the development guide.This PR also adds some missing documentation for the proto.
Why are the changes needed?
Does this PR introduce any user-facing change?
NO
How was this patch tested?
Existing UT