[SPARK-41213][CONNECT][PYTHON] Implement DataFrame.__repr__ and DataFrame.dtypes
#38735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Nov 21, 2022
| @@ -115,6 +115,9 @@ def __init__( | |||
| self._cache: Dict[str, Any] = {} | |||
| self._session: "RemoteSparkSession" = session | |||
|
|
|||
| def __repr__(self) -> str: | |||
| return "DataFrame[%s]" % (", ".join("%s: %s" % c for c in self.dtypes)) | |||
There was a problem hiding this comment.
this follows the default behavior of
spark/python/pyspark/sql/dataframe.py
Lines 860 to 869 in 40a9a6e
There was a problem hiding this comment.
Question: is this public API?
There was a problem hiding this comment.
it will be invoked here:
In [1]: df = spark.createDataFrame([(10, 80, "Alice"), (5, None, "Bob"), (None, 10, "Tom"), (None, None, None)], schema=["age", "height", "name"])
In [2]: df
Out[2]: DataFrame[age: bigint, height: bigint, name: string]
In [3]: df.__repr__()
Out[3]: 'DataFrame[age: bigint, height: bigint, name: string]'
HyukjinKwon
approved these changes
Nov 22, 2022
|
Merged to master. |
|
@HyukjinKwon thanks for the reviews |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…taFrame.dtypes` ### What changes were proposed in this pull request? Implement `DataFrame.__repr__` and `DataFrame.dtypes` ### Why are the changes needed? For api coverage ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? added UT Closes apache#38735 from zhengruifeng/connect_df_repr. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…taFrame.dtypes` ### What changes were proposed in this pull request? Implement `DataFrame.__repr__` and `DataFrame.dtypes` ### Why are the changes needed? For api coverage ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? added UT Closes apache#38735 from zhengruifeng/connect_df_repr. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…taFrame.dtypes` ### What changes were proposed in this pull request? Implement `DataFrame.__repr__` and `DataFrame.dtypes` ### Why are the changes needed? For api coverage ### Does this PR introduce _any_ user-facing change? yes ### How was this patch tested? added UT Closes apache#38735 from zhengruifeng/connect_df_repr. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement
DataFrame.__repr__andDataFrame.dtypesWhy are the changes needed?
For api coverage
Does this PR introduce any user-facing change?
yes
How was this patch tested?
added UT