[SPARK-41201][CONNECT][PYTHON][TEST][FOLLOWUP] Reenable test_fill_na #38763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM If you are interested in, can you BTW follow up in this PR on Basically I think these two case are not equivalent? They should be ? |
HyukjinKwon
approved these changes
Nov 23, 2022
|
@amaliujia that is on purpose, |
|
@zhengruifeng thanks for the clarification! |
|
merged into master |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? Reenable test_fill_na ### Why are the changes needed? `test_fill_na` was disabled by mistake in apache#38723 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? reenabled test Closes apache#38763 from zhengruifeng/connect_reenable_test_fillna. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Reenable test_fill_na ### Why are the changes needed? `test_fill_na` was disabled by mistake in apache#38723 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? reenabled test Closes apache#38763 from zhengruifeng/connect_reenable_test_fillna. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reenable test_fill_na
Why are the changes needed?
test_fill_nawas disabled by mistake in #38723Does this PR introduce any user-facing change?
no
How was this patch tested?
reenabled test