[SPARK-41346][CONNECT][PYTHON][FOLLOWUP] test_connect_function cleanup
#38886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Dec 2, 2022
grundprinzip
approved these changes
Dec 2, 2022
HyukjinKwon
reviewed
Dec 5, 2022
|
thank you! merged into master |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? remove unused tables, variables in `test_connect_function` ### Why are the changes needed? `test_connect_function` does not need a saved table at all ### Does this PR introduce _any_ user-facing change? No, test only ### How was this patch tested? updated test Closes apache#38886 from zhengruifeng/function_test_cleanup. Lead-authored-by: Ruifeng Zheng <ruifengz@apache.org> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
remove unused tables, variables in
test_connect_functionWhy are the changes needed?
test_connect_functiondoes not need a saved table at allDoes this PR introduce any user-facing change?
No, test only
How was this patch tested?
updated test