[SPARK-41369][CONNECT][BUILD][FOLLOW-UP] Update connect server module name #38957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Dec 7, 2022
|
Merged to master. |
hvanhovell
reviewed
Dec 7, 2022
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| <artifactId>spark-connect_2.12</artifactId> | |||
| <packaging>jar</packaging> | |||
| <name>Spark Project Connect</name> | |||
| <name>Spark Project Connect Server</name> | |||
There was a problem hiding this comment.
We should also update the actual name of the project. We can do that in a follow-up.
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
… name ### What changes were proposed in this pull request? The current maven package is not showing connect server as the name: <img width="574" alt="Screen Shot 2022-12-06 at 8 27 04 PM" src="https://user-images.githubusercontent.com/1938382/206088497-1e3af988-d6cb-473d-9e99-23f4827349ef.png"> This PR changes the name to match that it is a server module now: <img width="602" alt="Screen Shot 2022-12-06 at 8 45 13 PM" src="https://user-images.githubusercontent.com/1938382/206090633-241fc348-1b89-4d6a-9b03-499ff914c247.png"> ### Why are the changes needed? Showing correct name when run maven package. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? N/A Closes apache#38957 from amaliujia/update_module_name. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current maven package is not showing connect server as the name:
This PR changes the name to match that it is a server module now:
Why are the changes needed?
Showing correct name when run maven package.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
N/A