[SPARK-41444][CONNECT] Support read.json() #38975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Dec 8, 2022
| @@ -121,6 +121,23 @@ def test_simple_read(self): | |||
| # Check that the limit is applied | |||
| self.assertEqual(len(data.index), 10) | |||
|
|
|||
| def test_json(self): | |||
There was a problem hiding this comment.
Should better add a JIRA number here but let me get this in first.
HyukjinKwon
approved these changes
Dec 8, 2022
|
Merged to master. |
HyukjinKwon
changed the title
|
LGTM |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? This PR supports the `json()` API in DataFrameReader. This API is built on top of the core API of the reader (schema, load, option, etc.) Loading data is the first and important step for users to try Spark Connect while JSON files are one of the most popular file formats. ### Why are the changes needed? API coverage ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#38975 from amaliujia/have_json. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR supports the
json()API in DataFrameReader. This API is built on top of the core API of the reader (schema, load, option, etc.)Loading data is the first and important step for users to try Spark Connect while JSON files are one of the most popular file formats.
Why are the changes needed?
API coverage
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT