Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-5096] Use sbt tasks instead of vals to get hadoop version #3905

Closed
wants to merge 1 commit into from

Conversation

marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Jan 6, 2015

This makes it possible to compile spark as an external ProjectRef where as now we throw a FileNotFoundException

@SparkQA
Copy link

SparkQA commented Jan 6, 2015

Test build #25089 has started for PR 3905 at commit fd63aae.

  • This patch merges cleanly.

@marmbrus
Copy link
Contributor Author

marmbrus commented Jan 6, 2015

/cc @andrewor14

I'm throwing away the special casing for network-yarn/assembly... but even on master:

> network-yarn/assembly
[error] Expected ID character
[error] Not a valid command: network-yarn
[error] Expected project ID
[error] Expected configuration
[error] Expected ':' (if selecting a configuration)
[error] Expected key
[error] Not a valid key: network-yarn
[error] network-yarn/assembly

Is this okay?

@SparkQA
Copy link

SparkQA commented Jan 6, 2015

Test build #25089 has finished for PR 3905 at commit fd63aae.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25089/
Test PASSed.

@andrewor14
Copy link
Contributor

Hm I think we need to keep the network yarn jar called the same as before in both SBT and maven. Other than that I believe it's ok to not support network-yarn/assembly.

@pwendell
Copy link
Contributor

I thin this is good for now, I can pull it in.

@asfgit asfgit closed this in 6999910 Jan 18, 2015
@marmbrus marmbrus deleted the effectivePom branch February 17, 2015 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants