[SPARK-41428][UI] Protobuf serializer for SpeculationStageSummaryWrapper #39108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techaddict
changed the title
|
@gengliangwang this PR is ready to be reviewed |
|
@techaddict Do you mind if I hold on the PR review for one day and wait for the refactor in #39148? |
|
@gengliangwang sounds good 👍🏼 |
|
@techaddict FYI #39148 is merged. Can you resolve the conflicts? |
|
@techaddict updated the PR |
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto
Outdated
Show resolved
Hide resolved
gengliangwang
approved these changes
Dec 21, 2022
|
@gengliangwang addressed comments 👍🏼 |
|
Thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add Protobuf serializer for SpeculationStageSummaryWrapper
Why are the changes needed?
Support fast and compact serialization/deserialization for SpeculationStageSummaryWrapper over RocksDB.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New UT