[SPARK-41582][CORE][SQL] Reuse INVALID_TYPED_LITERAL instead of _LEGACY_ERROR_TEMP_0022
#39122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Dec 19, 2022
| Literal(Hex.decodeHex(padding + value)) | ||
| } catch { | ||
| case e: DecoderException => | ||
| val ex = QueryParsingErrors.cannotParseValueTypeError("X", value, ctx) |
There was a problem hiding this comment.
Pass X?HEX or HEXBINARY?
LuciferYang
commented
Dec 19, 2022
| Seq("DATE", "TIMESTAMP_NTZ", "TIMESTAMP_LTZ", "TIMESTAMP", "INTERVAL", "X"), | ||
| ctx) | ||
| } | ||
| } catch { |
There was a problem hiding this comment.
Seems only line 2439 will throw IllegalArgumentException, let's test
MaxGekk
approved these changes
Dec 20, 2022
| Literal(Hex.decodeHex(padding + value)) | ||
| } catch { | ||
| case e: DecoderException => | ||
| val ex = QueryParsingErrors.cannotParseValueTypeError("X", value, ctx) |
|
+1, LGTM. Merging to master. |
|
Thanks @MaxGekk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims reuse
INVALID_TYPED_LITERALinstead of_LEGACY_ERROR_TEMP_0022.Why are the changes needed?
Proper names of error classes to improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
Yes, the PR changes user-facing error message.
How was this patch tested?
Pass GitHub Actions