[SPARK-41637][SQL] ORDER BY ALL #39144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
commented
Dec 21, 2022
|
|
||
| override def apply(plan: LogicalPlan): LogicalPlan = plan.resolveOperatorsUpWithPruning( | ||
| _.containsAllPatterns(UNRESOLVED_ATTRIBUTE, SORT), ruleId) { | ||
| // This only makes sense if the children is resolved. |
There was a problem hiding this comment.
nit: child, not children
|
cc @cloud-fan this one too. seems much easier than group by all. |
| @@ -0,0 +1,44 @@ | |||
| create temporary view data as select * from values | |||
There was a problem hiding this comment.
nit: we can have a test case combining group by all and order by all. It should work, just for covering a testing scenario.
There was a problem hiding this comment.
isn't it better to test different features in different golden files?
There was a problem hiding this comment.
Oh you mean test both feature in one query? That's a good idea, we can add later.
gengliangwang
approved these changes
Dec 22, 2022
cloud-fan
approved these changes
Dec 23, 2022
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds ORDER BY ALL support to SQL. ORDER BY ALL is a syntactic sugar to sort the output by all the fields, from left to right. It also allows specifying asc/desc as well as null ordering.
Why are the changes needed?
It's a good convenience sugar added initially by DuckDB to avoid repeating the fields.
Does this PR introduce any user-facing change?
Yes. See above.
How was this patch tested?
Added SQL tests.