[SPARK-41649][CONNECT] Deduplicate docstrings in pyspark.sql.connect.window #39180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Dec 22, 2022
|
Merged to master. |
| rangeBetween.__doc__ = PySparkWindow.rangeBetween.__doc__ | ||
|
|
||
|
|
||
| Window.__doc__ = Window.__doc__ |
There was a problem hiding this comment.
@HyukjinKwon is this a typo?
There was a problem hiding this comment.
Yes :-). Mind creating a followup?
HyukjinKwon
pushed a commit
that referenced
this pull request
Dec 27, 2022
…l.connect.window ### What changes were proposed in this pull request? This PR is a followup of #39180 that addresses a typo. `Window.__doc__ = Window.__doc__` ### Why are the changes needed? For easier maintenance ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA Closes #39238 from bjornjorgensen/window-doc-PySparkWindowSpec. Authored-by: Bjørn Jørgensen <47577197+bjornjorgensen@users.noreply.github.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to deduplicate docstrings in
pyspark.sql.connect.window.Why are the changes needed?
For easier maintenance
Does this PR introduce any user-facing change?
No, dev-only. There're mintor doc changes that mention about remote support in Apache Spark 3.4.
How was this patch tested?
No test. It has to be manually verified until we resolve SPARK-41653.