Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-41580][SQL] Assign name to _LEGACY_ERROR_TEMP_2137 #39305

Closed
wants to merge 4 commits into from

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Dec 30, 2022

What changes were proposed in this pull request?

This PR proposes to assign name to _LEGACY_ERROR_TEMP_2137, "INVALID_JSON_ROOT_FIELD".

Why are the changes needed?

We should assign proper name to LEGACY_ERROR_TEMP*

Does this PR introduce any user-facing change?

No

How was this patch tested?

./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*

@itholic itholic marked this pull request as ready for review December 30, 2022 14:02
core/src/main/resources/error/error-classes.json Outdated Show resolved Hide resolved
core/src/main/resources/error/error-classes.json Outdated Show resolved Hide resolved
@itholic
Copy link
Contributor Author

itholic commented Jan 3, 2023

Thanks, @MaxGekk !
Just applied the comments

@MaxGekk
Copy link
Member

MaxGekk commented Jan 5, 2023

+1, LGTM. Merging to master.
Thank you, @itholic.

@MaxGekk MaxGekk closed this in 4d3bc8f Jan 5, 2023
@itholic itholic deleted the LEGACY_2137 branch April 22, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants