[SPARK-41800][BUILD] Upgrade commons-compress to 1.22 #39326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
commented
Dec 31, 2022
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-compress</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
There was a problem hiding this comment.
Use CountingOutputStream class, so direct dependency should be added
There was a problem hiding this comment.
Do you know why this is required by 1.22 only?
There was a problem hiding this comment.
I will investigate root cause.
There was a problem hiding this comment.
If this isn't just a breaking change in commons-compress, then I feel like we have two different versions of common-compress in play, which could explain why just adding the dependency explicitly changed behavior
|
Can one of the admins verify this patch? |
panbingkun
changed the title
srowen
approved these changes
Jan 5, 2023
dongjoon-hyun
changed the title
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade commons-compress from 1.21 to 1.22
Why are the changes needed?
This will bring the latest improvements.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.