[SPARK-41742][SPARK-41745][CONNECT] Reenable doc tests and add missing column alias to count() #39330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
requested changes
Dec 31, 2022
There was a problem hiding this comment.
Thank you, @grundprinzip . Your main contribution is adding alias to def count in group.py. Could you revise the PR title?
|
Sure, I'll revise. Though I'd say that the "contribution" is rather checking that the previously disabled tests actually pass. |
grundprinzip
changed the title
HyukjinKwon
approved these changes
Dec 31, 2022
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cleanup previously disabled test cases. In addition, add a column alias to the "count()" method without arguments for compatibility with PySpark.
Why are the changes needed?
Compatibility
Does this PR introduce any user-facing change?
No
How was this patch tested?
Reenabling doc tests.