Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-41554] fix changing of Decimal scale when scale decreased by m… #39381

Closed
wants to merge 3 commits into from
Closed

[SPARK-41554] fix changing of Decimal scale when scale decreased by m… #39381

wants to merge 3 commits into from

Conversation

fe2s
Copy link
Contributor

@fe2s fe2s commented Jan 4, 2023

…ore than 18

This is a backport PR for #39099

@github-actions github-actions bot added the SQL label Jan 4, 2023
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Jan 24, 2023

Is there a backport for 3.3. too?

@fe2s
Copy link
Contributor Author

fe2s commented Jan 31, 2023

Is there a backport for 3.3. too?

Created #39813. Sorry for the delay.

@srowen
Copy link
Member

srowen commented Jan 31, 2023

Roger that - any chance you can retrigger these tests? they're hung for some reason

@srowen
Copy link
Member

srowen commented Feb 2, 2023

I'll merge these if we can get tests to re-run, try retriggering them

@fe2s
Copy link
Contributor Author

fe2s commented Feb 2, 2023

I'll merge these if we can get tests to re-run, try retriggering them

I tried retriggering with a new push above, but it didn't help, seems like the tests passed, but it was still 'Queued - Test results' status on this page.

I've just retriggered them again, but now from the github UI. Let's see.

@srowen
Copy link
Member

srowen commented Feb 3, 2023

I'm confused, it looks like it succeeded if I click through to the results. Maybe it has succeeded? I guess I can assume so

srowen pushed a commit that referenced this pull request Feb 3, 2023
@srowen
[SPARK-41554] fix changing of Decimal scale when scale decreased by m…
d304a65 
…ore than 18

This is a backport PR for #39099

Closes #39381 from fe2s/branch-3.2-fix-decimal-scaling.

Authored-by: oleksii.diagiliev <oleksii.diagiliev@workday.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
@srowen
Copy link
Member

srowen commented Feb 3, 2023

I merged to 3.2. The relevant test(s) has/have actually passed

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label May 15, 2023
@github-actions github-actions bot closed this May 16, 2023
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
@parthchandra
[SPARK-41554] fix changing of Decimal scale when scale decreased by m…
6a7d784 
…ore than 18

This is a backport PR for apache#39099

Closes apache#39381 from fe2s/branch-3.2-fix-decimal-scaling.

Authored-by: oleksii.diagiliev <oleksii.diagiliev@workday.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
SQL Stale
Projects
None yet
Milestone
No milestone
3 participants
@fe2s @AmplabJenkins @srowen