[SPARK-41833][SPARK-41881][SPARK-41815][CONNECT][PYTHON] Make DataFrame.collect handle None/NaN/Array/Binary porperly
#39386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
DataFrame.collect handle ArrayType and BinaryType porperlyDataFrame.collect handle ArrayType and BinaryType porperly
zhengruifeng
force-pushed
the
connect_fix_41833
branch
from
8d54dfa
to
32ea86f
Compare
zhengruifeng
changed the title
DataFrame.collect handle ArrayType and BinaryType porperlyDataFrame.collect handle None/NaN/Array/Binary porperly
zhengruifeng
force-pushed
the
connect_fix_41833
branch
from
32ea86f
to
bee5a32
Compare
zhengruifeng
force-pushed
the
connect_fix_41833
branch
from
bee5a32
to
8b69df3
Compare
HyukjinKwon
approved these changes
Jan 4, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Existing
DataFrame.collectdirectly collect coming Arrow batches into a Pandas DataFrame, and then convert each series into a Row, which is problematic since it can not correctly handle None/NaN/Arrays/Binary/etc.This PR refactor
DataFrame.collectby directly building rows from the raw Arrow Table, in order to support:1, None/NaN values;
2, ArrayType
3, BinaryType
Why are the changes needed?
To be consistent with PySpark
Does this PR introduce any user-facing change?
yes
How was this patch tested?
enabled doctests