[SPARK-41871][CONNECT] DataFrame hint parameter can be str, float or int #39393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
previously approved these changes
Jan 4, 2023
HyukjinKwon
dismissed
their stale review
Actually Spark Connect does not have _jdf
HyukjinKwon
reviewed
Jan 4, 2023
|
@HyukjinKwon adding list to this would require more changes in proto definition, I'm not super familiar with proto3, but it doesn't support extending and we can't do repeated oneof either. |
|
yeah that's fine. |
HyukjinKwon
reviewed
Jan 5, 2023
techaddict
changed the title
HyukjinKwon
approved these changes
Jan 5, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark Connect DataFrame hint parameter can be str, list, float, or int. This is done in parity with pyspark DataFrame.hint
Why are the changes needed?
For parity
Does this PR introduce any user-facing change?
yes, allows more types as parameters.
How was this patch tested?
Enabling existing tests