Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-41985][SQL] Centralize more column resolution rules #39508

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/resources/error/error-classes.json
Original file line number Diff line number Diff line change
Expand Up @@ -1532,6 +1532,11 @@
"Referencing a lateral column alias <lca> in the aggregate function <aggFunc>."
]
},
"LATERAL_COLUMN_ALIAS_IN_GROUP_BY" : {
"message" : [
"Referencing a lateral column alias via GROUP BY alias/ALL is not supported yet."
]
},
"LATERAL_JOIN_USING" : {
"message" : [
"JOIN USING with LATERAL correlation."
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB

// Fail if we still have an unresolved all in group by. This needs to run before the
// general unresolved check below to throw a more tailored error message.
ResolveGroupByAll.checkAnalysis(operator)
ResolveReferencesInAggregate.checkUnresolvedGroupByAll(operator)

getAllExpressions(operator).foreach(_.foreachUp {
case a: Attribute if !a.resolved =>
Expand Down Expand Up @@ -762,8 +762,8 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog with QueryErrorsB

private def getAllExpressions(plan: LogicalPlan): Seq[Expression] = {
plan match {
// `groupingExpressions` may rely on `aggregateExpressions`, due to the GROUP BY alias
// feature. We should check errors in `aggregateExpressions` first.
// We only resolve `groupingExpressions` if `aggregateExpressions` is resolved first (See
// `ResolveReferencesInAggregate`). We should check errors in `aggregateExpressions` first.
case a: Aggregate => a.aggregateExpressions ++ a.groupingExpressions
case _ => plan.expressions
}
Expand Down

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

Loading