[SPARK-42078][PYTHON] Migrate errors thrown by JVM into PySparkException.
#39591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CORE
MLLIB
PANDAS API ON SPARK
PYTHON
SQL
STRUCTURED STREAMING
labels
HyukjinKwon
reviewed
Jan 16, 2023
HyukjinKwon
reviewed
Jan 16, 2023
HyukjinKwon
reviewed
Jan 16, 2023
HyukjinKwon
reviewed
Jan 16, 2023
HyukjinKwon
reviewed
Jan 17, 2023
HyukjinKwon
reviewed
Jan 17, 2023
HyukjinKwon
reviewed
Jan 17, 2023
HyukjinKwon
reviewed
Jan 18, 2023
HyukjinKwon
approved these changes
Jan 18, 2023
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 17, 2023
### What changes were proposed in this pull request? This is follow-up for #39591 based on the suggestions from comment 1de8350#r109023188. ### Why are the changes needed? For backward compatibility. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass Closes #40816 from itholic/42078-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 17, 2023
### What changes were proposed in this pull request? This is follow-up for #39591 based on the suggestions from comment 1de8350#r109023188. ### Why are the changes needed? For backward compatibility. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass Closes #40816 from itholic/42078-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 0457219) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This is follow-up for apache#39591 based on the suggestions from comment apache@1de8350#r109023188. ### Why are the changes needed? For backward compatibility. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass Closes apache#40816 from itholic/42078-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 0457219) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
GladwinLee
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? This is follow-up for apache#39591 based on the suggestions from comment apache@1de8350#r109023188. ### Why are the changes needed? For backward compatibility. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass Closes apache#40816 from itholic/42078-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 0457219) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Oct 10, 2023
### What changes were proposed in this pull request? This is follow-up for apache#39591 based on the suggestions from comment apache@1de8350#r109023188. ### Why are the changes needed? For backward compatibility. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass Closes apache#40816 from itholic/42078-followup. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 0457219) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to migrate errors thrown by JVM into
PySparkException.Here is the full list of errors suggesting migration:
In short, this PR proposes to migrate all exceptions from
pyspark/sql/utils.pyintopyspark/errors/exceptions.pyand fix them to inheritPySparkException.Why are the changes needed?
Because the errors thrown by JVM side (e.g.
AnalysisException,ParseException,IllegalArgumentException... ) are managed bypyspark/sql/utils.pywhich is not very correct place to handle the PySpark errors so far.Now we have separate error package
pyspark.errorswhich is introduced from #39387, we should centralize whole errors generated by PySpark side into single management point.So, here I suggest that all errors occurring in the JVM inherit PySparkException so that errors can be managed consistently.
Does this PR introduce any user-facing change?
No, this PR suggests to improve an internal error handling structure without any user-facing change.
How was this patch tested?
The existing CI should pass.