Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-42087][SQL][TESTS] Use --no-same-owner when HiveExternalCatalogVersionsSuite untars #39601

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to use a new parameter --no-same-owner when HiveExternalCatalogVersionsSuite untars

Why are the changes needed?

BEFORE

root@edeccfee6d53:/spark# tar xfz spark-3.3.1-bin-hadoop3.tgz
root@edeccfee6d53:/spark# ls -al spark-3.3.1-bin-hadoop3
total 96
drwxr-xr-x  17 110302528 1000   544 Oct 15 10:32 .
drwxr-xr-x   4 root      root   128 Jan 16 07:30 ..
-rw-r--r--   1 root      root 22940 Oct 15 10:32 LICENSE
-rw-r--r--   1 root      root 57842 Oct 15 10:32 NOTICE
drwxr-xr-x   3 110302528 1000    96 Oct 15 10:32 R
-rw-r--r--   1 root      root  4461 Oct 15 10:32 README.md
-rw-r--r--   1 root      root   165 Oct 15 10:32 RELEASE
drwxr-xr-x  29 110302528 1000   928 Oct 15 10:32 bin
drwxr-xr-x   8 110302528 1000   256 Oct 15 10:32 conf
drwxr-xr-x   5 110302528 1000   160 Oct 15 10:32 data
drwxr-xr-x   4 110302528 1000   128 Oct 15 10:32 examples
drwxr-xr-x 250 110302528 1000  8000 Oct 15 10:32 jars
drwxr-xr-x   4 110302528 1000   128 Oct 15 10:32 kubernetes
drwxr-xr-x  60 110302528 1000  1920 Oct 15 10:32 licenses
drwxr-xr-x  19 110302528 1000   608 Oct 15 10:32 python
drwxr-xr-x  29 110302528 1000   928 Oct 15 10:32 sbin
drwxr-xr-x   3 110302528 1000    96 Oct 15 10:32 yarn

AFTER

root@edeccfee6d53:/spark# tar xfz spark-3.3.1-bin-hadoop3.tgz --no-same-owner
root@edeccfee6d53:/spark# ls -al spark-3.3.1-bin-hadoop3
total 96
drwxr-xr-x  17 root root   544 Oct 15 10:32 .
drwxr-xr-x   4 root root   128 Jan 16 07:34 ..
-rw-r--r--   1 root root 22940 Oct 15 10:32 LICENSE
-rw-r--r--   1 root root 57842 Oct 15 10:32 NOTICE
drwxr-xr-x   3 root root    96 Oct 15 10:32 R
-rw-r--r--   1 root root  4461 Oct 15 10:32 README.md
-rw-r--r--   1 root root   165 Oct 15 10:32 RELEASE
drwxr-xr-x  29 root root   928 Oct 15 10:32 bin
drwxr-xr-x   8 root root   256 Oct 15 10:32 conf
drwxr-xr-x   5 root root   160 Oct 15 10:32 data
drwxr-xr-x   4 root root   128 Oct 15 10:32 examples
drwxr-xr-x 250 root root  8000 Oct 15 10:32 jars
drwxr-xr-x   4 root root   128 Oct 15 10:32 kubernetes
drwxr-xr-x  60 root root  1920 Oct 15 10:32 licenses
drwxr-xr-x  19 root root   608 Oct 15 10:32 python
drwxr-xr-x  29 root root   928 Oct 15 10:32 sbin
drwxr-xr-x   3 root root    96 Oct 15 10:32 yarn

Does this PR introduce any user-facing change?

No. This is a test-only improvement.

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the SQL label Jan 16, 2023
@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @viirya ? This was tested on a CI system which runs as root.

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon ! Merged to master for Apache Spark 3.4.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-42087 branch January 16, 2023 12:16
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants