[SPARK-42097][CORE] Register SerializedLambda and BitSet to KryoSerializer
#39621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
SerializedLambda and BitSet to KryoSerializer
dongjoon-hyun
commented
Jan 17, 2023
There was a problem hiding this comment.
Could you review this please, @viirya ? I caught this by running TPCDS in the cluster. It was a little difficult to add a test case for these like SerializedLambda.
viirya
approved these changes
Jan 17, 2023
|
Thank you, @viirya ! |
HyukjinKwon
approved these changes
Jan 17, 2023
|
Thank you, @HyukjinKwon . |
|
This is manually tested. Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to register
SerializedLambdaandBitSetto KryoSerializer.Why are the changes needed?
Although SPARK-42074 enabled
spark.kryo.registrationRequiredinTPCDSQueryBenchmark,SerializedLambdaandBitSetseems to occur during code gen part.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.