New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-40303][DOCS] Deprecate old Java 8 versions prior to 8u362 #39671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we simply deprecate, @wangyum ?
- Java 8 prior to version 8u201 support is deprecated as of Spark 3.2.0.
+ Java 8 prior to version 8u362 support is deprecated as of Spark 3.4.0.
Oh, does I cannot find docker image and Adoptium (Temurin) Java yet. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM for Apache Spark 3.4.0.
cc @srowen , @HyukjinKwon , @xinrong-meng , @LuciferYang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM, thanks @wangyum
One problem is that GA is still using Temurin 8u352 for build and test. We need to wait for a while before running GA tasks using 8u362. |
Could you use 8u362 to run full UTs offline to check compatibility? Thanks ~ @wangyum |
To @LuciferYang , I don't think this is a compatibility issue or any failure. |
@dongjoon-hyun Hmm...do you remember SPARK-40846? When we upgrade from 8u345 to 8u352 for GA testing, there are some time zone issue that need to be solved by changing the code, so I am not sure whether it is the right time to directly recommend a Java version without GA verification in the document. But maybe I'm too conservative. |
Timezone issues are inevitable which we need to adjust the code in a regular basis, @LuciferYang . |
BTW, we didn't cut the branch yet and we still have one month for Apache Spark 3.4.0 release. I'm considering that time period for this decision, @LuciferYang . You are also correct and being conservative is better if we don't have a room like that. |
Ok, plenty of time. I am fine to make this change |
What changes were proposed in this pull request?
This PR aims to deprecate old Java 8 versions prior to 8u362.
Why are the changes needed?
8u362 fixed a performance issue: openjdk/jdk8u-dev#161
Benchmark code:
8u352 benchmark result:
8u362 benchmark result:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A.