[SPARK-42043][CONNECT][TEST][FOLLOWUP] Fix jar finding bug and use better env vars and time measurement #39677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HyukjinKwon @LuciferYang Thanks for the review. I address the immediate fix in this PR. |
dongjoon-hyun
changed the title
|
Hi, @zhenlineo . When we use the same JIRA id, we need to add |
| val jars = recursiveListFiles(parentDir).filter { f => | ||
| // SBT jar | ||
| (f.getParentFile.getName.startsWith("scala-") && | ||
| f.getName.startsWith("spark-connect-assembly") && f.getName.endsWith("SNAPSHOT.jar")) || | ||
| f.getName.startsWith("spark-connect-assembly") && f.getName.endsWith(".jar")) || |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Jan 20, 2023
HyukjinKwon
approved these changes
Jan 21, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixed the jar finding bug for RC builds. ([WIP] Test 3.4.0 tagging #39668)
Use a better env var to find the spark home in E2E tests.
Use Nano instead of MS for elapsed time measurement.
Why are the changes needed?
Bug fix and improvements.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.