[SPARK-18011] Fix SparkR NA date serialization #39681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
HyukjinKwon
approved these changes
Jan 23, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR ensures that SparkR serializes
NAdates as"NA"(string) to avoid an undefined length when deserializing in the JVM.Why are the changes needed?
Currently, SparkR assumes that a
NegativeArraySizeExceptionwhen deserializing dates and timestamps represents anNA. However, this handling can be made more robust by ensuring that serialization on the R side always provides a valid string length (note thatnchar(as.character(as.Date(NA)))isNA).Does this PR introduce any user-facing change?
No
How was this patch tested?