Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-41757][CONNECT][PYTHON][FOLLOW-UP] Enable connect.functions.col doctest #39761

Closed
wants to merge 1 commit into from

Conversation

techaddict
Copy link
Contributor

@techaddict techaddict commented Jan 26, 2023

What changes were proposed in this pull request?

To reenable the doc tests for col Function, this patch makes the string representation of the Column closer to the regular PySpark Column.

This PR is a follow up to #39616 with enabling col doctests

Why are the changes needed?

Improve Coverage

Does this PR introduce any user-facing change?

No

How was this patch tested?

Reenabled doc tests.

@techaddict techaddict changed the title [SPARK-41757][CONNECT][TESTS][FOLLOW-UP] Enable connect.functions.col doctest [SPARK-41757][CONNECT][PYTHON][FOLLOW-UP] Enable connect.functions.col doctest Jan 26, 2023
@HyukjinKwon
Copy link
Member

Merged to master and branch-3.4.

HyukjinKwon pushed a commit that referenced this pull request Jan 27, 2023
…l doctest

### What changes were proposed in this pull request?
To reenable the doc tests for `col` Function, this patch makes the string representation of the Column closer to the regular PySpark Column.

This PR is a follow up to #39616 with enabling col doctests

### Why are the changes needed?
Improve Coverage

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
Reenabled doc tests.

Closes #39761 from techaddict/SPARK-41757-2.

Authored-by: Sandeep Singh <sandeep@techaddict.me>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 2f49c1f)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants