Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-42192][PYTHON] Migrate the TypeError from pyspark/sql/dataframe.py into PySparkTypeError #39785

Closed
wants to merge 11 commits into from

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Jan 28, 2023

What changes were proposed in this pull request?

This PR proposes to migrate the TypeError from pyspark/sql/dataframe.py into PySparkTypeError.

Why are the changes needed?

To integrate the errors generated by PySpark into single path.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Added & updated UTs.

@HyukjinKwon
Copy link
Member

LGTM if tests pass

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.4.

HyukjinKwon pushed a commit that referenced this pull request Jan 31, 2023
…rame.py` into `PySparkTypeError`

### What changes were proposed in this pull request?

This PR proposes to migrate the `TypeError` from `pyspark/sql/dataframe.py` into `PySparkTypeError`.

### Why are the changes needed?

To integrate the errors generated by PySpark into single path.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Added & updated UTs.

Closes #39785 from itholic/error_dataframe.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit a1362b1)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@itholic itholic deleted the error_dataframe branch April 22, 2023 05:48
zhengruifeng pushed a commit that referenced this pull request Apr 27, 2023
… type

### What changes were proposed in this pull request?

This is follow-up for #39785 to address improper error class and error type.

### Why are the changes needed?

We should use proper error class and error type for PySpark errors.

### Does this PR introduce _any_ user-facing change?

No, it's error correction

### How was this patch tested?

The existing CI should pass

Closes #40965 from itholic/error_frame_followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
LuciferYang pushed a commit to LuciferYang/spark that referenced this pull request May 10, 2023
… type

### What changes were proposed in this pull request?

This is follow-up for apache#39785 to address improper error class and error type.

### Why are the changes needed?

We should use proper error class and error type for PySpark errors.

### Does this PR introduce _any_ user-facing change?

No, it's error correction

### How was this patch tested?

The existing CI should pass

Closes apache#40965 from itholic/error_frame_followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
…rame.py` into `PySparkTypeError`

### What changes were proposed in this pull request?

This PR proposes to migrate the `TypeError` from `pyspark/sql/dataframe.py` into `PySparkTypeError`.

### Why are the changes needed?

To integrate the errors generated by PySpark into single path.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Added & updated UTs.

Closes apache#39785 from itholic/error_dataframe.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit a1362b1)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants