[SPARK-42229][CORE] Migrate SparkCoreErrors into error classes
#39791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
approved these changes
Jan 31, 2023
|
+1, LGTM. Merging to master. |
|
@itholic Could you open a PR w/ a backport to 3.4. |
itholic
added a commit
to itholic/spark
that referenced
this pull request
Feb 1, 2023
### What changes were proposed in this pull request? This PR proposes to migrate SparkCoreErrors into `_LEGACY_ERROR_TEMP_` error classes. ### Why are the changes needed? To leverage the error message framework for better error message handling. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually tested, the existing CI should pass. Closes apache#39791 from itholic/SPARK-42229. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
Backport: #39832 |
MaxGekk
pushed a commit
that referenced
this pull request
Feb 1, 2023
### What changes were proposed in this pull request? backport for #39791 ### Why are the changes needed? We should want to include PRs related to error classes into Spark 3.4. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The CI should pass. Closes #39832 from itholic/42229-3.4. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? backport for apache#39791 ### Why are the changes needed? We should want to include PRs related to error classes into Spark 3.4. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The CI should pass. Closes apache#39832 from itholic/42229-3.4. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to migrate SparkCoreErrors into
_LEGACY_ERROR_TEMP_error classes.Why are the changes needed?
To leverage the error message framework for better error message handling.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested, the existing CI should pass.