[SPARK-42279][PS][TESTS] Simplify pyspark.pandas.tests.test_resample
#39847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
changed the title
test_resamplepyspark.pandas.tests.test_resample
|
master: https://github.com/apache/spark/actions/runs/4063229672/jobs/6995258363 in this PR |
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Feb 2, 2023
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 2, 2023
### What changes were proposed in this pull request? Simplify `test_resample` ### Why are the changes needed? `test_resample` may take more than 20min, this PR remove redundant combinations. In my local env, 249 sec -> 30 sec. ### Does this PR introduce _any_ user-facing change? No, test only ### How was this patch tested? updated tests Closes #39847 from zhengruifeng/pandas_opt_test_resample. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 9043224) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Simplify `test_resample` ### Why are the changes needed? `test_resample` may take more than 20min, this PR remove redundant combinations. In my local env, 249 sec -> 30 sec. ### Does this PR introduce _any_ user-facing change? No, test only ### How was this patch tested? updated tests Closes apache#39847 from zhengruifeng/pandas_opt_test_resample. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 9043224) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify
test_resampleWhy are the changes needed?
test_resamplemay take more than 20min, this PR remove redundant combinations.In my local env, 249 sec -> 30 sec.
Does this PR introduce any user-facing change?
No, test only
How was this patch tested?
updated tests