[SPARK-42333][SQL] Change log level to debug when fetching result set from SparkExecuteStatementOperation #39876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatementOperation
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 3, 2023
… from SparkExecuteStatementOperation ### What changes were proposed in this pull request? Change log level from info to debug when fetching result set from `SparkExecuteStatementOperation`. ### Why are the changes needed? Avoid generating too many logs: <img width="1230" alt="image" src="https://user-images.githubusercontent.com/5399861/216561187-6ad00458-d196-4f3a-a314-b2f309aec482.png"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test. Closes #39876 from wangyum/SPARK-42333. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4ebfc0e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Merged to master/3.4. Thank you, @wangyum . |
LuciferYang
reviewed
Feb 3, 2023
| @@ -96,7 +96,7 @@ private[hive] class SparkExecuteStatementOperation( | |||
| private def getNextRowSetInternal( | |||
| order: FetchOrientation, | |||
| maxRowsL: Long): TRowSet = withLocalProperties { | |||
| log.info(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " + | |||
| log.debug(s"Received getNextRowSet request order=${order} and maxRowsL=${maxRowsL} " + | |||
There was a problem hiding this comment.
hmm... @wangyum @dongjoon-hyun
should we change to use
if (log.isDebugEnabled) {
log.debug( ... )
}
or logDebug(...) here?
Using log.debug directly may not avoid the cost of string splicing ？
There was a problem hiding this comment.
IIUC, this is not a perf critical path, @LuciferYang . In addition, the goal of this PR is not to avoid costs. Instead, it aims UX, Avoid generating too many logs:.
Anyway, you can suggest that in general for perf perspective.
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
… from SparkExecuteStatementOperation ### What changes were proposed in this pull request? Change log level from info to debug when fetching result set from `SparkExecuteStatementOperation`. ### Why are the changes needed? Avoid generating too many logs: <img width="1230" alt="image" src="https://user-images.githubusercontent.com/5399861/216561187-6ad00458-d196-4f3a-a314-b2f309aec482.png"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Unit test. Closes apache#39876 from wangyum/SPARK-42333. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4ebfc0e) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change log level from info to debug when fetching result set from
SparkExecuteStatementOperation.Why are the changes needed?
Avoid generating too many logs:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.