[SPARK-42348][SQL] Add new SQLSTATE #39886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
commented
Feb 5, 2023
Comment on lines
+860
to
+870
| |42KD0 |42 |Syntax error or Access Rule violation |KD0 |Ambiguous name reference. |Databricks |N |Databricks | | ||
| |42KD1 |42 |Syntax error or Access Rule violation |KD1 |Operation not supported in READ ONLY session mode. |Databricks |N |Databricks | | ||
| |42KD2 |42 |Syntax error or Access Rule violation |KD2 |The source and target table names of a SYNC operaton must be the same.|Databricks |N |Databricks | | ||
| |42KD3 |42 |Syntax error or Access Rule violation |KD3 |A column can not be added as specified. |Databricks |N |Databricks | | ||
| |42KD4 |42 |Syntax error or Access Rule violation |KD4 |Operation not supported because table schema has changed. |Databricks |N |Databricks | | ||
| |42KD5 |42 |Syntax error or Access Rule violation |KD5 |Cannot create file or path. |Databricks |N |Databricks | | ||
| |42KD6 |42 |Syntax error or Access Rule violation |KD6 |No partition information found. |Databricks |N |Databricks | | ||
| |42KD7 |42 |Syntax error or Access Rule violation |KD7 |Table signature mismatch. |Databricks |N |Databricks | | ||
| |42KD8 |42 |Syntax error or Access Rule violation |KD8 |Column position out of range. |Databricks |N |Databricks | | ||
| |42KD9 |42 |Syntax error or Access Rule violation |KD9 |Cannot infer table schema. |Databricks |N |Databricks | | ||
| |42KDA |42 |Syntax error or Access Rule violation |KDA |Failed to merge file into table schema. |Databricks |N |Databricks | |
There was a problem hiding this comment.
cc @srielau do we want to add those SQLSTATE to core/src/main/resources/error/README.md ?
Otherwise, we can't use them in error class because we only allow the SQLSTATE specified in core/src/main/resources/error/README.md.
For example, we cannot apply #39871 (comment).
There was a problem hiding this comment.
Also cc @MaxGekk @cloud-fan
cloud-fan
approved these changes
Feb 6, 2023
|
thanks, merging to master/3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 6, 2023
### What changes were proposed in this pull request? This PR proposes to add new SQLSTATE defined from Databricks to `core/src/main/resources/error/README.md`. ### Why are the changes needed? We should use proper SQLSTATE for every SQL error classes. Otherwise, it fails on `SparkThrowableSuite.SQLSTATE invariants` test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass. Closes #39886 from itholic/MISSING_SQLSTATE. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 188e608) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR proposes to add new SQLSTATE defined from Databricks to `core/src/main/resources/error/README.md`. ### Why are the changes needed? We should use proper SQLSTATE for every SQL error classes. Otherwise, it fails on `SparkThrowableSuite.SQLSTATE invariants` test. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass. Closes apache#39886 from itholic/MISSING_SQLSTATE. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 188e608) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add new SQLSTATE defined from Databricks to
core/src/main/resources/error/README.md.Why are the changes needed?
We should use proper SQLSTATE for every SQL error classes.
Otherwise, it fails on
SparkThrowableSuite.SQLSTATE invariantstest.Does this PR introduce any user-facing change?
No.
How was this patch tested?
The existing CI should pass.