[SPARK-42265][SPARK-41820][CONNECT] Fix createTempView and its variations to work with not analyzed plans #39968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 10, 2023
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 12, 2023
…ions to work with not analyzed plans Fixes `createTempView` and its variations to work with not analyzed plans. - `createTempView` - `createOrReplaceTempView` - `createGlobalTempView` - `createOrReplaceGlobalTempView` Currently `SparkConnectPlanner` creates `CreateViewCommand` with `isAnalyzed = true`, but the child plan can be not-analyzed yet. Users can run `createTempView` and its variations with not analyzed plans. Enabled the related tests. Closes #39968 from ueshin/issues/SPARK-41279/createTempView. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 90be059) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…ions to work with not analyzed plans Fixes `createTempView` and its variations to work with not analyzed plans. - `createTempView` - `createOrReplaceTempView` - `createGlobalTempView` - `createOrReplaceGlobalTempView` Currently `SparkConnectPlanner` creates `CreateViewCommand` with `isAnalyzed = true`, but the child plan can be not-analyzed yet. Users can run `createTempView` and its variations with not analyzed plans. Enabled the related tests. Closes apache#39968 from ueshin/issues/SPARK-41279/createTempView. Authored-by: Takuya UESHIN <ueshin@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 90be059) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes
createTempViewand its variations to work with not analyzed plans.createTempViewcreateOrReplaceTempViewcreateGlobalTempViewcreateOrReplaceGlobalTempViewWhy are the changes needed?
Currently
SparkConnectPlannercreatesCreateViewCommandwithisAnalyzed = true, but the child plan can be not-analyzed yet.Does this PR introduce any user-facing change?
Users can run
createTempViewand its variations with not analyzed plans.How was this patch tested?
Enabled the related tests.