[SPARK-42034] QueryExecutionListener and Observation API do not work with foreach / reduce / foreachPartition action.
#39976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Feb 13, 2023
| @@ -960,6 +960,19 @@ class DatasetSuite extends QueryTest | |||
| observe(spark.range(1, 10, 1, 11), Map("percentile_approx_val" -> 5)) | |||
| } | |||
|
|
|||
| test("observation on datasets when a DataSet trigger foreach action") { | |||
There was a problem hiding this comment.
Suggested change
| test("observation on datasets when a DataSet trigger foreach action") { | |
| test("SPARK-42034: observation on datasets when a DataSet trigger foreach action") { |
HyukjinKwon
reviewed
Feb 13, 2023
| @@ -96,6 +96,34 @@ class DataFrameCallbackSuite extends QueryTest | |||
| spark.listenerManager.unregister(listener) | |||
| } | |||
|
|
|||
| test("execute callback functions when a DataSet trigger foreach action finished") { | |||
There was a problem hiding this comment.
Suggested change
| test("execute callback functions when a DataSet trigger foreach action finished") { | |
| test("SPARK-42034: execute callback functions when a DataSet trigger foreach action finished") { |
HyukjinKwon
reviewed
Feb 13, 2023
| assert(metrics(0)._1 == "foreach") | ||
| assert(metrics(1)._1 == "reduce") | ||
|
|
||
| spark.listenerManager.unregister(listener) |
There was a problem hiding this comment.
I would add this into finally so the test failure of this doesn't affect other tests.
There was a problem hiding this comment.
I know other tests don't. but let's at least do it here.
HyukjinKwon
approved these changes
Feb 13, 2023
|
@HyukjinKwon Thank you for ping me. |
|
Merged to master. |
|
Thanks @HyukjinKwon @beliefer |
|
this wouldn't fix the |
|
Thanks. Made a followup: #43304 |
HyukjinKwon
added a commit
that referenced
this pull request
Oct 10, 2023
…eachPartition in JdbcUtils ### What changes were proposed in this pull request? This PR is kind of a followup for #39976 that addresses #39976 (comment) comment. ### Why are the changes needed? In order to probably assign the SQL execution ID so `df.observe` works with this. ### Does this PR introduce _any_ user-facing change? Yes. `df.observe` will work with JDBC connectors. ### How was this patch tested? Manually tested. ### Was this patch authored or co-authored using generative AI tooling? Unit test was added. Closes #43304 from HyukjinKwon/foreachbatch. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Oct 10, 2023
…eachPartition in JdbcUtils This PR is kind of a followup for #39976 that addresses #39976 (comment) comment. In order to probably assign the SQL execution ID so `df.observe` works with this. Yes. `df.observe` will work with JDBC connectors. Manually tested. Unit test was added. Closes #43304 from HyukjinKwon/foreachbatch. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 39cc4ab) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Oct 11, 2023
…D.foreachPartition in JdbcUtils This PR cherry-picks #43304 to branch-3.5 --- ### What changes were proposed in this pull request? This PR is kind of a followup for #39976 that addresses #39976 (comment) comment. ### Why are the changes needed? In order to probably assign the SQL execution ID so `df.observe` works with this. ### Does this PR introduce _any_ user-facing change? Yes. `df.observe` will work with JDBC connectors. ### How was this patch tested? Manually tested. ### Was this patch authored or co-authored using generative AI tooling? Unit test was added. Closes #43322 from HyukjinKwon/SPARK-45475-3.5. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the name parameter for 'foreach'/'reduce'/'foreachPartition' operators in
DataSet#withNewRDDExecutionId. Because the QueryExecutionListener and Observation API is triggered only when the operators have the name parameter.spark/sql/core/src/main/scala/org/apache/spark/sql/util/QueryExecutionListener.scala
Line 181 in 84ddd40
Why are the changes needed?
The QueryExecutionListener and Observation API is triggered only when the operators have the name parameter.
Does this PR introduce any user-facing change?
No
How was this patch tested?
add two unit test.