Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-42524][BUILD] Upgrade numpy and pandas in the release Dockerfile #40111

Closed
wants to merge 1 commit into from

Conversation

xinrong-meng
Copy link
Member

What changes were proposed in this pull request?

Upgrade pandas from 1.1.5 to 1.5.3, numpy from 1.19.4 to 1.20.3 in the Dockerfile used for Spark releases.

They are also what we use to cut v3.4.0-rc1.

Why are the changes needed?

Otherwise, errors are raised as shown below when building release docs.

ImportError: Warning: Latest version of pandas (1.5.3) is required to generate the documentation; however, your version was 1.1.5

ImportError: this version of pandas is incompatible with numpy < 1.20.3
your numpy version is 1.19.4.
Please upgrade numpy to >= 1.20.3 to use this pandas version

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual tests.

@xinrong-meng xinrong-meng changed the title [WIP] Upgrade numpy and pandas in the release Dockerfile [SPARK-42524][BUILD] Upgrade numpy and pandas in the release Dockerfile Feb 22, 2023
@xinrong-meng xinrong-meng marked this pull request as ready for review February 22, 2023 01:57
@HyukjinKwon
Copy link
Member

Merged to master and branch-3.4.

HyukjinKwon pushed a commit that referenced this pull request Feb 22, 2023
### What changes were proposed in this pull request?
Upgrade pandas from 1.1.5 to 1.5.3, numpy from 1.19.4 to 1.20.3 in the Dockerfile used for Spark releases.

They are also what we use to cut `v3.4.0-rc1`.

### Why are the changes needed?
Otherwise, errors are raised as shown below when building release docs.
```
ImportError: Warning: Latest version of pandas (1.5.3) is required to generate the documentation; however, your version was 1.1.5

ImportError: this version of pandas is incompatible with numpy < 1.20.3
your numpy version is 1.19.4.
Please upgrade numpy to >= 1.20.3 to use this pandas version
```

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Manual tests.

Closes #40111 from xinrong-meng/docker_lib.

Authored-by: Xinrong Meng <xinrong@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit d09742b)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, too.

snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
### What changes were proposed in this pull request?
Upgrade pandas from 1.1.5 to 1.5.3, numpy from 1.19.4 to 1.20.3 in the Dockerfile used for Spark releases.

They are also what we use to cut `v3.4.0-rc1`.

### Why are the changes needed?
Otherwise, errors are raised as shown below when building release docs.
```
ImportError: Warning: Latest version of pandas (1.5.3) is required to generate the documentation; however, your version was 1.1.5

ImportError: this version of pandas is incompatible with numpy < 1.20.3
your numpy version is 1.19.4.
Please upgrade numpy to >= 1.20.3 to use this pandas version
```

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Manual tests.

Closes apache#40111 from xinrong-meng/docker_lib.

Authored-by: Xinrong Meng <xinrong@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit d09742b)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants