[SPARK-42534][SQL][3.4] Fix DB2Dialect Limit clause #40155
Closed
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR fixes DB2 Limit clause syntax. Although DB2 supports LIMIT keyword, it seems that this support varies across databases and versions and the recommended way is to use `FETCH FIRST x ROWS ONLY`. In fact, some versions don't support LIMIT at all. Doc: https://www.ibm.com/docs/en/db2/11.5?topic=subselect-fetch-clause, usage example: https://www.mullinsconsulting.com/dbu_0502.htm. Fixes the incorrect Limit clause which could cause errors when using against DB2 versions that don't support LIMIT. No. I added a unit test and an integration test to cover this functionality. Closes apache#40134 from sadikovi/db2-limit-fix. Authored-by: Ivan Sadikov <ivan.sadikov@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
|
@cloud-fan I opened the backport for 3.4 but there is no JDBC query builder commit in 3.4 so one of the tests was removed. |
cloud-fan
approved these changes
Feb 24, 2023
|
thanks, merging to 3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 24, 2023
### What changes were proposed in this pull request? The PR fixes DB2 Limit clause syntax. Although DB2 supports LIMIT keyword, it seems that this support varies across databases and versions and the recommended way is to use `FETCH FIRST x ROWS ONLY`. In fact, some versions don't support LIMIT at all. Doc: https://www.ibm.com/docs/en/db2/11.5?topic=subselect-fetch-clause, usage example: https://www.mullinsconsulting.com/dbu_0502.htm. ### Why are the changes needed? Fixes the incorrect Limit clause which could cause errors when using against DB2 versions that don't support LIMIT. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I added a unit test and an integration test to cover this functionality. Closes #40155 from sadikovi/db2-limit-fix-3.4. Authored-by: Ivan Sadikov <ivan.sadikov@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? The PR fixes DB2 Limit clause syntax. Although DB2 supports LIMIT keyword, it seems that this support varies across databases and versions and the recommended way is to use `FETCH FIRST x ROWS ONLY`. In fact, some versions don't support LIMIT at all. Doc: https://www.ibm.com/docs/en/db2/11.5?topic=subselect-fetch-clause, usage example: https://www.mullinsconsulting.com/dbu_0502.htm. ### Why are the changes needed? Fixes the incorrect Limit clause which could cause errors when using against DB2 versions that don't support LIMIT. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I added a unit test and an integration test to cover this functionality. Closes apache#40155 from sadikovi/db2-limit-fix-3.4. Authored-by: Ivan Sadikov <ivan.sadikov@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR fixes DB2 Limit clause syntax. Although DB2 supports LIMIT keyword, it seems that this support varies across databases and versions and the recommended way is to use
FETCH FIRST x ROWS ONLY. In fact, some versions don't support LIMIT at all. Doc: https://www.ibm.com/docs/en/db2/11.5?topic=subselect-fetch-clause, usage example: https://www.mullinsconsulting.com/dbu_0502.htm.Why are the changes needed?
Fixes the incorrect Limit clause which could cause errors when using against DB2 versions that don't support LIMIT.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I added a unit test and an integration test to cover this functionality.