[SPARK-42600][SQL] CatalogImpl.currentDatabase shall use NamespaceHelper instead of MultipartIdentifierHelper #40192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of MultipartIdentifierHelper ```java Exception in thread "main" org.apache.spark.sql.AnalysisException: Multi-part identifier cannot be empty. at org.apache.spark.sql.errors.QueryCompilationErrors$.emptyMultipartIdentifierError(QueryCompilationErrors.scala:1887) at org.apache.spark.sql.connector.catalog.CatalogV2Implicits$MultipartIdentifierHelper.<init>(CatalogV2Implicits.scala:152) at org.apache.spark.sql.connector.catalog.CatalogV2Implicits$.MultipartIdentifierHelper(CatalogV2Implicits.scala:150) at org.apache.spark.sql.internal.CatalogImpl.currentDatabase(CatalogImpl.scala:65) ```
cloud-fan
reviewed
Feb 27, 2023
| @@ -62,7 +62,7 @@ class CatalogImpl(sparkSession: SparkSession) extends Catalog { | |||
| * Returns the current default database in this session. | |||
| */ | |||
| override def currentDatabase: String = | |||
| sparkSession.sessionState.catalogManager.currentNamespace.toSeq.quoted | |||
| sparkSession.sessionState.catalogManager.currentNamespace.quoted | |||
There was a problem hiding this comment.
hmm does this make a difference?
There was a problem hiding this comment.
oh I see. It's so tricky to have implicit class for both Seq[String] and Array[String]. We should clean it up in the future.
There was a problem hiding this comment.
It's so tricky to have implicit class for both Seq[String] and Array[String]
Yea 👀
cloud-fan
approved these changes
Feb 28, 2023
|
thanks, merging to master/3.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Feb 28, 2023
…per instead of MultipartIdentifierHelper ### What changes were proposed in this pull request? v2 catalog default namespace may be empty ```java Exception in thread "main" org.apache.spark.sql.AnalysisException: Multi-part identifier cannot be empty. at org.apache.spark.sql.errors.QueryCompilationErrors$.emptyMultipartIdentifierError(QueryCompilationErrors.scala:1887) at org.apache.spark.sql.connector.catalog.CatalogV2Implicits$MultipartIdentifierHelper.<init>(CatalogV2Implicits.scala:152) at org.apache.spark.sql.connector.catalog.CatalogV2Implicits$.MultipartIdentifierHelper(CatalogV2Implicits.scala:150) at org.apache.spark.sql.internal.CatalogImpl.currentDatabase(CatalogImpl.scala:65) ``` ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? locally verified Closes #40192 from yaooqinn/SPARK-42600. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 53c4158) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…per instead of MultipartIdentifierHelper ### What changes were proposed in this pull request? v2 catalog default namespace may be empty ```java Exception in thread "main" org.apache.spark.sql.AnalysisException: Multi-part identifier cannot be empty. at org.apache.spark.sql.errors.QueryCompilationErrors$.emptyMultipartIdentifierError(QueryCompilationErrors.scala:1887) at org.apache.spark.sql.connector.catalog.CatalogV2Implicits$MultipartIdentifierHelper.<init>(CatalogV2Implicits.scala:152) at org.apache.spark.sql.connector.catalog.CatalogV2Implicits$.MultipartIdentifierHelper(CatalogV2Implicits.scala:150) at org.apache.spark.sql.internal.CatalogImpl.currentDatabase(CatalogImpl.scala:65) ``` ### Why are the changes needed? bugfix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? locally verified Closes apache#40192 from yaooqinn/SPARK-42600. Authored-by: Kent Yao <yao@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 53c4158) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
v2 catalog default namespace may be empty
Why are the changes needed?
bugfix
Does this PR introduce any user-facing change?
no
How was this patch tested?
locally verified