[SPARK-42614][CONNECT] Make constructors private[sql] #40207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Feb 28, 2023
zhengruifeng
approved these changes
Feb 28, 2023
|
It seems that |
|
Scala/Java linter passed. Merged to master/3.4. Thank you, @hvanhovell and all! |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Feb 28, 2023
### What changes were proposed in this pull request? Tiny PR to make most of the scala client classes have a private[sql] constructor. ### Why are the changes needed? Consistency, safety for the future. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Closes #40207 from hvanhovell/SPARK-42614. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 43baed1) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Tiny PR to make most of the scala client classes have a private[sql] constructor. ### Why are the changes needed? Consistency, safety for the future. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No Closes apache#40207 from hvanhovell/SPARK-42614. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 43baed1) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tiny PR to make most of the scala client classes have a private[sql] constructor.
Why are the changes needed?
Consistency, safety for the future.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No