[SPARK-42639][CONNECT] Add createDataFrame/createDataset methods #40242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 60b9463.
HyukjinKwon
approved these changes
Mar 2, 2023
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 2, 2023
### What changes were proposed in this pull request? This PR adds all the `SparkSession.createDataFrame(..)` and `SparkSession.createDataset(..)` methods we can support in connect. The implicit conversion that uses this is also added. I moved the `ArrowWriter` class from sql/core to sql/catalyst for the arrow writing. ### Why are the changes needed? API partity with the existing SQL APIs ### Does this PR introduce _any_ user-facing change? Yes. ### How was this patch tested? I have added a number of tests to `ClientE2ETestSuite`. Closes #40242 from hvanhovell/SPARK-42639. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a9626d5) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Thank you, @hvanhovell and @HyukjinKwon . Merged to master/3.4. |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? This PR adds all the `SparkSession.createDataFrame(..)` and `SparkSession.createDataset(..)` methods we can support in connect. The implicit conversion that uses this is also added. I moved the `ArrowWriter` class from sql/core to sql/catalyst for the arrow writing. ### Why are the changes needed? API partity with the existing SQL APIs ### Does this PR introduce _any_ user-facing change? Yes. ### How was this patch tested? I have added a number of tests to `ClientE2ETestSuite`. Closes apache#40242 from hvanhovell/SPARK-42639. Authored-by: Herman van Hovell <herman@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit a9626d5) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds all the
SparkSession.createDataFrame(..)andSparkSession.createDataset(..)methods we can support in connect. The implicit conversion that uses this is also added.I moved the
ArrowWriterclass from sql/core to sql/catalyst for the arrow writing.Why are the changes needed?
API partity with the existing SQL APIs
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
I have added a number of tests to
ClientE2ETestSuite.