[SPARK-41725][PYTHON][TESTS][FOLLOW-UP] Remove collect for SQL command execution in tests #40251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
zhengruifeng
approved these changes
Mar 2, 2023
|
All related tests passed. Merged to master and branch-3.4. |
HyukjinKwon
added a commit
that referenced
this pull request
Mar 2, 2023
…d execution in tests
### What changes were proposed in this pull request?
This PR removes `sql("command").collect()` workaround in PySpark tests codes.
### Why are the changes needed?
They were added previously to work around within Spark Connect. This is fixed now, so we don't need to call `collect` anymore.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
CI in this PR should test it out.
Closes #40251 from HyukjinKwon/SPARK-41725.
Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 79da1ab)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…d execution in tests
### What changes were proposed in this pull request?
This PR removes `sql("command").collect()` workaround in PySpark tests codes.
### Why are the changes needed?
They were added previously to work around within Spark Connect. This is fixed now, so we don't need to call `collect` anymore.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
CI in this PR should test it out.
Closes apache#40251 from HyukjinKwon/SPARK-41725.
Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 79da1ab)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes
sql("command").collect()workaround in PySpark tests codes.Why are the changes needed?
They were added previously to work around within Spark Connect. This is fixed now, so we don't need to call
collectanymore.Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
CI in this PR should test it out.