[SPARK-42557][CONNECT] Add Broadcast to functions #40275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
reviewed
Mar 4, 2023
| * @since 3.4.0 | ||
| */ | ||
| def broadcast[T](df: Dataset[T]): Dataset[T] = { | ||
| df.hint("broadcast") |
hvanhovell
reviewed
Mar 4, 2023
| val left = spark.range(100).select(col("id"), rand(10).as("a")) | ||
| val right = spark.range(100).select(col("id"), rand(12).as("a")) | ||
| val joined = | ||
| left.join(broadcast(right), left("id") === right("id")).select(left("id"), right("a")) |
There was a problem hiding this comment.
can you check if we actually broadcast the right table?
hvanhovell
reviewed
Mar 4, 2023
hvanhovell
reviewed
Mar 4, 2023
| val joined = | ||
| left.join(broadcast(right), left("id") === right("id")).select(left("id"), right("a")) | ||
| assert(joined.schema.catalogString === "struct<id:bigint,a:double>") | ||
| testCapturedStdOut(joined.explain(), "BroadcastHashJoin") |
There was a problem hiding this comment.
For later: we should have a better way to get the plan.
hvanhovell
reviewed
Mar 4, 2023
| left.join(broadcast(right), left("id") === right("id")).select(left("id"), right("a")) | ||
| assert(joined.schema.catalogString === "struct<id:bigint,a:double>") | ||
| testCapturedStdOut(joined.explain(), "BroadcastHashJoin") | ||
| spark.conf.set("spark.sql.autoBroadcastJoinThreshold", "10MB") |
There was a problem hiding this comment.
Prefer to use try.. finally .. when you are resetting confs. That way failing tests do not start influencing others.
There was a problem hiding this comment.
Should we copy SQLHelper to client module later? withSQLConf and other functions are more useful
There was a problem hiding this comment.
@LuciferYang It's good idea. Let's do it later.
|
@LuciferYang I want support the similar |
|
@LuciferYang Thank you. |
|
Merging. |
hvanhovell
pushed a commit
that referenced
this pull request
Mar 6, 2023
### What changes were proposed in this pull request? Currently, the connect functions missing the broadcast API. This PR want add this API to connect's functions. ### Why are the changes needed? Add the broadcast function to connect's functions.scala. ### Does this PR introduce _any_ user-facing change? 'No'. New feature. ### How was this patch tested? New test cases. Closes #40275 from beliefer/SPARK-42557. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 94b50e0) Signed-off-by: Herman van Hovell <herman@databricks.com>
|
@hvanhovell @LuciferYang Thank you. |
hvanhovell
pushed a commit
that referenced
this pull request
Mar 20, 2023
…xclude` rule from mima check ### What changes were proposed in this pull request? #40275 has implemented the `functions#broadcast`, so this pr remove the corresponding `ProblemFilters.exclude` rule from `CheckConnectJvmClientCompatibility` ### Why are the changes needed? Remove `unnecessary` `ProblemFilters.exclude` rule. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual check `dev/connect-jvm-client-mima-check` passed Closes #40463 from LuciferYang/SPARK-42557-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Herman van Hovell <herman@databricks.com>
hvanhovell
pushed a commit
that referenced
this pull request
Mar 20, 2023
…xclude` rule from mima check ### What changes were proposed in this pull request? #40275 has implemented the `functions#broadcast`, so this pr remove the corresponding `ProblemFilters.exclude` rule from `CheckConnectJvmClientCompatibility` ### Why are the changes needed? Remove `unnecessary` `ProblemFilters.exclude` rule. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual check `dev/connect-jvm-client-mima-check` passed Closes #40463 from LuciferYang/SPARK-42557-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 6ad8bf4) Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
### What changes were proposed in this pull request? Currently, the connect functions missing the broadcast API. This PR want add this API to connect's functions. ### Why are the changes needed? Add the broadcast function to connect's functions.scala. ### Does this PR introduce _any_ user-facing change? 'No'. New feature. ### How was this patch tested? New test cases. Closes apache#40275 from beliefer/SPARK-42557. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 94b50e0) Signed-off-by: Herman van Hovell <herman@databricks.com>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…xclude` rule from mima check ### What changes were proposed in this pull request? apache#40275 has implemented the `functions#broadcast`, so this pr remove the corresponding `ProblemFilters.exclude` rule from `CheckConnectJvmClientCompatibility` ### Why are the changes needed? Remove `unnecessary` `ProblemFilters.exclude` rule. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual check `dev/connect-jvm-client-mima-check` passed Closes apache#40463 from LuciferYang/SPARK-42557-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Herman van Hovell <herman@databricks.com> (cherry picked from commit 6ad8bf4) Signed-off-by: Herman van Hovell <herman@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, the connect functions missing the broadcast API. This PR want add this API to connect's functions.
Why are the changes needed?
Add the broadcast function to connect's functions.scala.
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
New test cases.