-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5239][CORE]JdbcRDD throws "java.lang.AbstractMethodError: oracle.jdbc.driver.xxxxxx.isClosed()Z" #4033
Conversation
…le.jdbc.driver.xxxxxx.isClosed()Z'
Can one of the admins verify this patch? |
See comment in JIRA; this should not be hacked around because the JDBC driver is unsuitable. |
I take it back (see https://issues.apache.org/jira/browse/SPARK-5481) Yes, there's evidence of JDBC 3 drivers in the wild, still, and because I confirmed that Similar changes should be made in |
@luogankun do you want to augment this PR to include |
ok to test |
Test build #27040 has started for PR 4033 at commit
|
Test build #27040 has finished for PR 4033 at commit
|
Test PASSed. |
Close the PR. |
@luogankun are you going to make a new PR? or are you asking me to do so? you can just reopen and add to this PR. |
@srowen To do other things, forgot to resubmit a new PR after close the PR. Thanks for your help. |
NP I will assign to you @luogankun in any event for the credit. Right now the new PR fails Hive tests, twice, which is suspicious, though I can't see how it would affect behavior. I'm waiting to see if it's just flakiness or a real problem. |
The stacktrace message of all failure testcase are: |
…le.jdbc.driver.xxxxxx.isClosed()Z" This is a completion of #4033 which was withdrawn for some reason. Author: Sean Owen <sowen@cloudera.com> Closes #4470 from srowen/SPARK-5239.2 and squashes the following commits: 2398bde [Sean Owen] Avoid use of JDBC4-only isClosed() (cherry picked from commit 2d1e916) Signed-off-by: Sean Owen <sowen@cloudera.com>
…le.jdbc.driver.xxxxxx.isClosed()Z" This is a completion of #4033 which was withdrawn for some reason. Author: Sean Owen <sowen@cloudera.com> Closes #4470 from srowen/SPARK-5239.2 and squashes the following commits: 2398bde [Sean Owen] Avoid use of JDBC4-only isClosed()
rs.isClosed()
will throws:Similarly,
stmt.isClosed()
will throwsAbove exception is throwing because "isClosed()" is not implemented in the "OracleResultSetImpl" class which implements the ResultSet Interface in Ojdbc14.jar, I think use below condition to check whether resultset is null or not is enough