[WIP][SPARK-42715][SQL] Tips for Optimizing NegativeArraySizeException #40341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Mar 9, 2023
| @@ -204,7 +204,12 @@ public void initBatch( | |||
| * by copying from ORC VectorizedRowBatch columns to Spark ColumnarBatch columns. | |||
| */ | |||
| private boolean nextBatch() throws IOException { | |||
| recordReader.nextBatch(wrap.batch()); | |||
| try { | |||
There was a problem hiding this comment.
Will Parquet have the same issue?
There was a problem hiding this comment.
Thoughtful, i will make a test.
zzzzming95
reviewed
Mar 9, 2023
| recordReader.nextBatch(wrap.batch()); | ||
| try { | ||
| recordReader.nextBatch(wrap.batch()); | ||
| } catch (NegativeArraySizeException e) { |
There was a problem hiding this comment.
Is there a way to build unit test and catch the exception?
There was a problem hiding this comment.
Thanks for your ideas, they sound nice, i will make it done.
There was a problem hiding this comment.
I also encountered the same stack issue. How much adjustment would be appropriate. @chong0929
chong0929
changed the title
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In orc batch read, the byte arrays is used to store the data of the read columns. When the total data of this batch exceeds Int.MaxValue can be caused NegativeArraySizeException, catch and throw the same exeception with a friendly msg.
Why are the changes needed?
Friendly msg where read orc file get exception about java.lang.NegativeArraySizeException.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.