[SPARK-42725][CONNECT][PYTHON] Make LiteralExpression support array params #40349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
connect_py_ml_lit
branch
from
28004bc
to
012b9df
Compare
zhengruifeng
changed the title
zhengruifeng
changed the title
zhengruifeng
changed the title
HyukjinKwon
reviewed
Mar 9, 2023
| @@ -277,14 +281,26 @@ def _infer_type(cls, value: Any) -> DataType: | |||
| return DateType() | |||
| elif isinstance(value, datetime.timedelta): | |||
| return DayTimeIntervalType() | |||
| else: | |||
| elif isinstance(value, np.generic): | |||
| if isinstance(value, np.generic): | |||
HyukjinKwon
approved these changes
Mar 9, 2023
WeichenXu123
reviewed
Mar 9, 2023
| @@ -437,7 +436,6 @@ def test_literal_with_unsupported_type(self): | |||
| (0.1, DecimalType()), | |||
| (datetime.date(2022, 12, 13), TimestampType()), | |||
| (datetime.timedelta(1, 2, 3), DateType()), | |||
| ([1, 2, 3], ArrayType(IntegerType())), | |||
There was a problem hiding this comment.
Let's add test for Array<Array> type as well.
There was a problem hiding this comment.
arrayType was not support before, here just check the raised AssertionError
zhengruifeng
commented
Mar 9, 2023
| self.assertEqual(l2.array.elements[1].double, -3.0) | ||
| self.assertEqual(l2.array.elements[2].double, 0.0) | ||
|
|
||
| l3 = LiteralExpression._from_value([[3, 4], [5, 6, 7]]).to_plan(None).literal |
There was a problem hiding this comment.
@WeichenXu123 l3 and l4 are array < array >
zhengruifeng
force-pushed
the
connect_py_ml_lit
branch
from
012b9df
to
3411ecd
Compare
add a test for array_string
zhengruifeng
force-pushed
the
connect_py_ml_lit
branch
from
3411ecd
to
518ffb2
Compare
zhengruifeng
added a commit
that referenced
this pull request
Mar 10, 2023
…arams ### What changes were proposed in this pull request? Make LiteralExpression support array ### Why are the changes needed? MLIib requires literal to carry the array params, like `IntArrayParam`, `DoubleArrayArrayParam`. Note that this PR doesn't affect existing `functions.lit` method which apply unresolved `CreateArray` expression to support array input. ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? added UT Closes #40349 from zhengruifeng/connect_py_ml_lit. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit d6d0fc7) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
|
merged into master/branch-3.4 |
LuciferYang
reviewed
Mar 11, 2023
| DataType elementType = 1; | ||
| repeated Literal element = 2; | ||
| DataType element_type = 1; | ||
| repeated Literal elements = 2; |
There was a problem hiding this comment.
When I first defined it, I confirmed to @hvanhovell that it should be element rather than elements , so I defined it as element.
At the same time, I found that we sometimes use the singular and sometimes the plural in the definition of the repeated field.
I think we should have a unified rule.
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…arams ### What changes were proposed in this pull request? Make LiteralExpression support array ### Why are the changes needed? MLIib requires literal to carry the array params, like `IntArrayParam`, `DoubleArrayArrayParam`. Note that this PR doesn't affect existing `functions.lit` method which apply unresolved `CreateArray` expression to support array input. ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? added UT Closes apache#40349 from zhengruifeng/connect_py_ml_lit. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit d6d0fc7) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make LiteralExpression support array
Why are the changes needed?
MLIib requires literal to carry the array params, like
IntArrayParam,DoubleArrayArrayParam.Note that this PR doesn't affect existing
functions.litmethod which apply unresolvedCreateArrayexpression to support array input.Does this PR introduce any user-facing change?
No, dev-only
How was this patch tested?
added UT