Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][SQL][FOLLOWUP] Fix scalastyle in LimitPushDownThroughWindow #40386

Closed
wants to merge 1 commit into from
Closed

[MINOR][SQL][FOLLOWUP] Fix scalastyle in LimitPushDownThroughWindow #40386

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 12, 2023

What changes were proposed in this pull request?

Although this is weird because of `[MINOR][SQL][FOLLOWUP]'. This PR aims to recover the CI failure on the master branch from the following commit.

c75b3ab

Why are the changes needed?

Screenshot 2023-03-12 at 1 23 49 PM

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the SQL label Mar 12, 2023
@dongjoon-hyun
Copy link
Member Author

cc @wangyum and @kenny-ddd

@dongjoon-hyun
Copy link
Member Author

Scala linter passed.

Screenshot 2023-03-12 at 1 59 52 PM

@dongjoon-hyun
Copy link
Member Author

Hi, @bjornjorgensen . Could you review this PR?

@dongjoon-hyun
Copy link
Member Author

Could you review this in order to recover master branch, @sunchao ?

@dongjoon-hyun
Copy link
Member Author

Since this is a comment only change, let me merge this to recover the master branch and PRs.

Screenshot 2023-03-12 at 2 20 11 PM

@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SCALASTYLE branch March 12, 2023 21:21
@bjornjorgensen
Copy link
Contributor

@dongjoon-hyun Thank you. Yes, this PR looks ok.

@dongjoon-hyun
Copy link
Member Author

Thank you so much, @bjornjorgensen .

@bjornjorgensen
Copy link
Contributor

I have seen this one time before. Can you restart tests on the PR that fails?

@dongjoon-hyun
Copy link
Member Author

No, only the PR author can do that because we use the author's GitHub Actions for that PR.

I have seen this one time before. Can you restart tests on the PR that fails?

For Apache Spark branch, of course, you can because you are the committer.

@bjornjorgensen
Copy link
Contributor

Seams to be working now :)

@LuciferYang
Copy link
Contributor

Thanks for your fix @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants