[SPARK-42764][K8S] Parameterize the max number of attempts for driver props fetcher in KubernetesExecutorBackend #40387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… props fetcher in KubernetesExecutorBackend
dongjoon-hyun
commented
Mar 13, 2023
| @@ -82,7 +82,7 @@ private[spark] object KubernetesExecutorBackend extends Logging { | |||
| clientMode = true) | |||
|
|
|||
| var driver: RpcEndpointRef = null | |||
| val nTries = 3 | |||
| val nTries = sys.env.getOrElse("EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTS", 3) | |||
There was a problem hiding this comment.
This env name came from the name of this RPCEnv.
|
Could you review this PR, @viirya ? |
viirya
approved these changes
Mar 13, 2023
viirya
reviewed
Mar 13, 2023
| @@ -82,7 +82,7 @@ private[spark] object KubernetesExecutorBackend extends Logging { | |||
| clientMode = true) | |||
|
|
|||
| var driver: RpcEndpointRef = null | |||
| val nTries = 3 | |||
| val nTries = sys.env.getOrElse("EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTS", 3).toInt | |||
There was a problem hiding this comment.
Do we need to document this parameter? Or it is just one internal parameter for test purpose only?
There was a problem hiding this comment.
Thank you for review. This is an internal parameter like .internal config. However, this code path is invoked to get SparkConf. So, we cannot use SparkConf value. We may document this env variable later in some debug section.
|
All tests passed. Merged to master. |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
… props fetcher in KubernetesExecutorBackend ### What changes were proposed in this pull request? This PR aims to parameterize the max number of attempts for driver props fetcher in `KubernetesExecutorBackend` by introducing a new environment variable, `EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTS`, for testing purpose. Note that this feature is proposed as a new environment variable because this happens before getting `SparkConf` from the driver. ### Why are the changes needed? In case of K8s network issues, the executor pods could fail with `UnknownHostException`. `EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTS` could be helpful in that case. ``` Caused by: java.io.IOException: Failed to connect to pi-....svc/<unresolved>:7078 Caused by: java.net.UnknownHostException: pi-....svc ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. Closes apache#40387 from dongjoon-hyun/SPARK-42764. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to parameterize the max number of attempts for driver props fetcher in
KubernetesExecutorBackendby introducing a new environment variable,EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTS, for testing purpose.Note that this feature is proposed as a new environment variable because this happens before getting
SparkConffrom the driver.Why are the changes needed?
In case of K8s network issues, the executor pods could fail with
UnknownHostException.EXECUTOR_DRIVER_PROPS_FETCHER_MAX_ATTEMPTScould be helpful in that case.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.