[SPARK-42720][PS][SQL] Uses expression for distributed-sequence default index instead of plan #40456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan @hvanhovell FYI |
...atalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/DistributedSequenceID.scala
Show resolved
Hide resolved
HyukjinKwon
force-pushed
the
SPARK-42720
branch
3 times, most recently
from
e98b674
to
dc74cdf
Compare
HyukjinKwon
force-pushed
the
SPARK-42720
branch
from
dc74cdf
to
1a812b0
Compare
|
BTW, according to the JIRA, this is only for Apache Spark 3.5? |
cloud-fan
reviewed
Mar 17, 2023
...yst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ExtractDistributedSequenceID.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 17, 2023
...yst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ExtractDistributedSequenceID.scala
Show resolved
Hide resolved
cloud-fan
reviewed
Mar 17, 2023
...yst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ExtractDistributedSequenceID.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Mar 20, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces
DataFrame.withSequenceColumntoDataFrame.select(distributed_sequence_column, col("*")internally because this essentially attaches a column and it should be treated as a scalar expression at the logical level.This is used to generate the unique index only for pandas API on Spark.
Why are the changes needed?
For better readability of codes, and for cleaner definition of Spark Connect protobuf message, see also #40270.
Does this PR introduce any user-facing change?
No, it's internal change only.
How was this patch tested?
Existing test cases in pandas API on Spark verify this change.