[SPARK-42930][CORE][SQL] Change the access scope of ProtobufSerDe related implementations to private[protobuf]
#40560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
ProtobufSerDe related implementations to private[spark]ProtobufSerDe related implementations to private[spark]
LuciferYang
commented
Mar 27, 2023
| @@ -25,7 +25,7 @@ import org.apache.spark.status.api.v1.AccumulableInfo | |||
| import org.apache.spark.status.protobuf.Utils.{getOptional, getStringField, setStringField} | |||
| import org.apache.spark.util.Utils.weakIntern | |||
|
|
|||
| private[protobuf] object AccumulableInfoSerializer { | |||
| private[spark] object AccumulableInfoSerializer { | |||
There was a problem hiding this comment.
cc @gengliangwang @dongjoon-hyun FYI
Do you prefer private[spark] or private[protobuf]?
Should ProtobufSerDe also be changed to private[spark]? Although it has been identified as @DeveloperApi
There was a problem hiding this comment.
Developer APIs are fine.
Do you prefer private[spark] or private[protobuf]?
Whichever narrower should be preferred.
There was a problem hiding this comment.
OK, Let me change to private[protobuf]
LuciferYang
changed the title
ProtobufSerDe related implementations to private[spark]ProtobufSerDe related implementations to private[protobuf]
dongjoon-hyun
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang and @HyukjinKwon .
Merged to master/3.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 27, 2023
…elated implementations to `private[protobuf]` ### What changes were proposed in this pull request? After [SPARK-41053](https://issues.apache.org/jira/browse/SPARK-41053), Spark supports serializing/ Live UI data to RocksDB using protobuf, but these are internal implementation details, so this pr change the access scope of `ProtobufSerDe` related implementations to `private[protobuf]`. ### Why are the changes needed? Weaker the access scope of Spark internal implementation details. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes #40560 from LuciferYang/SPARK-42930. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b8f16bc) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Thanks @dongjoon-hyun @HyukjinKwon |
|
+1, @LuciferYang Thanks for the work! |
|
Thanks @gengliangwang ~ |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…elated implementations to `private[protobuf]` ### What changes were proposed in this pull request? After [SPARK-41053](https://issues.apache.org/jira/browse/SPARK-41053), Spark supports serializing/ Live UI data to RocksDB using protobuf, but these are internal implementation details, so this pr change the access scope of `ProtobufSerDe` related implementations to `private[protobuf]`. ### Why are the changes needed? Weaker the access scope of Spark internal implementation details. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#40560 from LuciferYang/SPARK-42930. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b8f16bc) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After SPARK-41053, Spark supports serializing/ Live UI data to RocksDB using protobuf, but these are internal implementation details, so this pr change the access scope of
ProtobufSerDerelated implementations toprivate[protobuf].Why are the changes needed?
Weaker the access scope of Spark internal implementation details.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions