-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5012][MLLib][PySpark]Python API for Gaussian Mixture Model #4059
Conversation
Can one of the admins verify this patch? |
add to whitelist |
Test build #25609 has started for PR 4059 at commit
|
Test build #25609 has finished for PR 4059 at commit
|
Test FAILed. |
@FlytxtRnD Are you still running into the py4j serialization issue you mentioned on the JIRA? |
@jkbradley py4j serialization issue has been solved by the commit 8ead999 |
Test build #25634 has started for PR 4059 at commit
|
Test build #25634 has finished for PR 4059 at commit
|
Test FAILed. |
…ter' into PythonGmmWrapper
…nGmmWrapper' into PythonGmmWrapper Conflicts: examples/src/main/python/mllib/gaussian_mixture_model.py
Test build #25648 has started for PR 4059 at commit
|
Test build #25648 has finished for PR 4059 at commit
|
Test PASSed. |
…ter' into PythonGmmWrapper
import random | ||
import argparse | ||
import numpy as np | ||
from pyspark import SparkConf, SparkContext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
separate spark imports from python imports
Test build #26509 has started for PR 4059 at commit
|
Test build #26509 has finished for PR 4059 at commit
|
Test FAILed. |
Is it possible to start a test build in Jenkins without updating the PR? TestResults shows "no failures" but the console output shows errors. All tests were passed when ran locally. |
Test build #26515 has started for PR 4059 at commit
|
Test build #26515 has finished for PR 4059 at commit
|
Test PASSed. |
Please review and merge.. |
.setK(k) | ||
.setConvergenceTol(convergenceTol) | ||
.setMaxIterations(maxIterations) | ||
.setSeed(seed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default seed is not generated. If users don't specify seed on the Python side, it will pass in as null
on the JVM side.
if (seed != null) gmmAlg.setSeed(seed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In python side I have added a default value None ..So is it required to add this statement
…ter' into PythonGmmWrapper
Test build #26607 has started for PR 4059 at commit
|
Test build #26607 has finished for PR 4059 at commit
|
Test PASSed. |
LGTM. Merged into master. Thanks for adding GMM Python API! |
Thanks @mengxr for your help. |
Python API for the Gaussian Mixture Model clustering algorithm in MLLib.