[SPARK-42971][CORE] Change to print workdir if appDirs is null when worker handle WorkDirCleanup event
#40597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Mar 30, 2023
sadikovi
approved these changes
Mar 30, 2023
|
Merged to master and branch-3.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 30, 2023
…en worker handle `WorkDirCleanup` event ### What changes were proposed in this pull request? This pr change to print `workdir` if `appDirs` is null when worker handle `WorkDirCleanup` event. ### Why are the changes needed? Print `appDirs` ause a NPE because `appDirs` is null and from the context, what should be printed is `workdir` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes #40597 from LuciferYang/SPARK-39296-FOLLOW. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit f105fe8) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
Thanks @HyukjinKwon @sadikovi |
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Jun 20, 2023
…en worker handle `WorkDirCleanup` event ### What changes were proposed in this pull request? This pr change to print `workdir` if `appDirs` is null when worker handle `WorkDirCleanup` event. ### Why are the changes needed? Print `appDirs` ause a NPE because `appDirs` is null and from the context, what should be printed is `workdir` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#40597 from LuciferYang/SPARK-39296-FOLLOW. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit f105fe8) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr change to print
workdirifappDirsis null when worker handleWorkDirCleanupevent.Why are the changes needed?
Print
appDirsause a NPE becauseappDirsis null and from the context, what should be printed isworkdirDoes this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions