New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35198][CONNECT][CORE][PYTHON][SQL] Add support for calling debugCodegen from Python & Java #40608
Conversation
Add support for calling debugCodegen from Python & Java
LGTM +1 |
Add support for calling debugCodegen from Python & Java - versionadded:: 3.5.0
Add support for calling debugCodegen from Python & Java - exclude debugCodegen() method from MiMaCompatibility
@HyukjinKwon Changed the implementation to |
Hi @HyukjinKwon Does the PR approach make sense to you? |
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Hey @HyukjinKwon @MaxGekk @holdenk, I created this PR a while ago... I would appreciate if you have the chance to review it. |
LGTM for 4.0, can you update the version tags and then we'll merge to the dev branch? |
Thanks @holdenk. Updated the version tags to |
LGTM |
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Add support for calling debugCodegen from Python & Java
What changes were proposed in this pull request?
debugCodegen
to the Dataset APIs core and connectordebugCodegen
to the pyspark dataframe APIdebugCodegen
fromsql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala
as it is public now.Why are the changes needed?
To add a direct method to get debugCodegen state for Java & Python users of Dataframes.
Does this PR introduce any user-facing change?
debugCodegen
is now accessible from all Scala, python and Java APIs. See usage below.How was this patch tested?
Added tests in:
sql/core/src/test/scala/org/apache/spark/sql/DebugCodegenSuite.scala
.connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/ClientE2ETestSuite.scala
Local testing: