Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-42382][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.6 #40726

Closed
wants to merge 2 commits into from
Closed

[SPARK-42382][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.6 #40726

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 10, 2023 •
edited

What changes were proposed in this pull request?

This pr aims upgrade cyclonedx-maven-plugin to 2.7.6 for Apache Spark 3.5.0.

Why are the changes needed?

The release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions.
  • Manual check the cyclonedx.xml file can be generated normally.

@github-actions github-actions bot added the BUILD label Apr 10, 2023
dongjoon-hyun
dongjoon-hyun commented Apr 10, 2023
View reviewed changes
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @LuciferYang .
Since you've been investigating this so far, I made a PR with your main-authorship.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Apr 10, 2023
Closed
@dongjoon-hyun
Copy link
Member Author

R failure on AppVeyor is irrelevant to this PR.

@dongjoon-hyun
Copy link
Member Author

Could you review this PR, @viirya ? I verified manually.

$ ls -alt
total 67688
-rw-r--r--@  1 dongjoon  staff      1955 Apr 10 15:27 maven-metadata-local.xml
-rw-r--r--@  1 dongjoon  staff       492 Apr 10 15:27 _remote.repositories
-rw-r--r--@  1 dongjoon  staff   4451845 Apr 10 15:27 spark-core_2.12-3.5.0-SNAPSHOT-javadoc.jar
-rw-r--r--@  1 dongjoon  staff    362584 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-cyclonedx.json
-rw-r--r--@  1 dongjoon  staff    312338 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-cyclonedx.xml
-rw-r--r--@  1 dongjoon  staff   1423015 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-test-sources.jar
-rw-r--r--@  1 dongjoon  staff   2919170 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-sources.jar
-rw-r--r--@  1 dongjoon  staff   8078262 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT-tests.jar
-rw-r--r--@  1 dongjoon  staff  14038165 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT.jar
-rw-r--r--@  1 dongjoon  staff     44355 Apr 10 15:26 spark-core_2.12-3.5.0-SNAPSHOT.pom
drwxr-xr-x@  4 dongjoon  staff       128 Apr 10 14:56 ..
drwxr-xr-x@ 12 dongjoon  staff       384 Apr 10 14:56 .

$ head spark-core_2.12-3.5.0-SNAPSHOT-cyclonedx.xml
<?xml version="1.0" encoding="UTF-8"?>
<bom serialNumber="urn:uuid:14185927-0ca0-4589-92aa-268c9c81873d" version="1" xmlns="http://cyclonedx.org/schema/bom/1.4">
  <metadata>
    <timestamp>2023-04-10T22:26:52Z</timestamp>
    <tools>
      <tool>
        <vendor>OWASP Foundation</vendor>
        <name>CycloneDX Maven plugin makeBom compile+provided+runtime+system</name>
        <version>2.7.6</version>
        <hashes>

@HyukjinKwon
Copy link
Member

Merged to master.

@HyukjinKwon
Copy link
Member

Hm, for some reasons, it shows @LuciferYang as a primary author. I manually changed it to @dongjoon-hyun.

@dongjoon-hyun
Copy link
Member Author

Oh, it was intentional #40726 (review), but thank you!

Thank you, @HyukjinKwon and @viirya !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-42382 branch April 10, 2023 23:57
@LuciferYang
Copy link
Contributor

late LGTM ~ Thanks @dongjoon-hyun and all ~

@steveloughran
Copy link
Contributor

this working OK on the latest maven releases that homebrew is pushing out?

@dongjoon-hyun
Copy link
Member Author

To @steveloughran , this is done independently from Maven.
I verified in Apache ORC and Spark community only for now.

This was referenced Apr 13, 2023
Closed
Closed
Merged
dongjoon-hyun added a commit to dongjoon-hyun/parquet-mr that referenced this pull request Apr 13, 2023
@dongjoon-hyun
PARQUET-2275: Upgrade cyclonedx-maven-plugin to 2.7.6
d6bdb99 
This PR aims to upgrade `cyclonedx-maven-plugin` from `2.7.3` to `2.7.6` to bring the latest bug fixes.

- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.6
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.5
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.4

Historically, there was some issue reports on the previous versions with the latest Maven.
- apache/spark#40065
- apache/arrow#35086

Now, 2.7.6 is verified in Apache Spark, ORC, Arrow community as of today.
- [ORC-1407: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/orc#1463)
- [SPARK-42382: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/spark#40726)
- [GH-35086: Upgrade CycloneDX Maven plugin version](apache/arrow#35092)
Fokko pushed a commit to apache/parquet-java that referenced this pull request Apr 13, 2023
@dongjoon-hyun
PARQUET-2275: Upgrade cyclonedx-maven-plugin to 2.7.6 (#1057)
370fb14 
This PR aims to upgrade `cyclonedx-maven-plugin` from `2.7.3` to `2.7.6` to bring the latest bug fixes.

- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.6
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.5
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.4

Historically, there was some issue reports on the previous versions with the latest Maven.
- apache/spark#40065
- apache/arrow#35086

Now, 2.7.6 is verified in Apache Spark, ORC, Arrow community as of today.
- [ORC-1407: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/orc#1463)
- [SPARK-42382: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/spark#40726)
- [GH-35086: Upgrade CycloneDX Maven plugin version](apache/arrow#35092)
@dongjoon-hyun dongjoon-hyun mentioned this pull request Apr 13, 2023
Merged
4 tasks
a0x8o added a commit to a0x8o/parquet-mr that referenced this pull request Apr 13, 2023
@a0x8o
PARQUET-2275: Upgrade cyclonedx-maven-plugin to 2.7.6 (#1057)
aa5e064 
This PR aims to upgrade `cyclonedx-maven-plugin` from `2.7.3` to `2.7.6` to bring the latest bug fixes.

- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.6
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.5
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.4

Historically, there was some issue reports on the previous versions with the latest Maven.
- apache/spark#40065
- apache/arrow#35086

Now, 2.7.6 is verified in Apache Spark, ORC, Arrow community as of today.
- [ORC-1407: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/orc#1463)
- [SPARK-42382: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/spark#40726)
- [GH-35086: Upgrade CycloneDX Maven plugin version](apache/arrow#35092)
@dongjoon-hyun dongjoon-hyun mentioned this pull request Apr 13, 2023
Merged
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
@dongjoon-hyun @LuciferYang
[SPARK-42382][BUILD] Upgrade cyclonedx-maven-plugin to 2.7.6
18391d2 
### What changes were proposed in this pull request?
This pr aims upgrade `cyclonedx-maven-plugin` to 2.7.6 for Apache Spark 3.5.0.

### Why are the changes needed?
The release notes as follows:

- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.4
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.5
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.6

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

- Pass GitHub Actions.
- Manual check the `cyclonedx.xml` file can be generated normally.

Closes apache#40726 from dongjoon-hyun/SPARK-42382.

Lead-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Co-authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
BUILD
Projects
None yet
Milestone
No milestone
5 participants
@dongjoon-hyun @HyukjinKwon @LuciferYang @steveloughran @viirya